Christoph Hellwig <hch@xxxxxx> wrote: > > (1) afs_write_back_from_locked_folio() could be called directly rather > > than calling filemap_fdatawrite_wbc(), but that would avoid the > > control group stuff that wbc_attach_and_unlock_inode() and co. seem to > > do. Do I actually need to do this? > > That would be much preferred over the for_write_begin hack, given that > write_begin really isn't a well defined method but a hacky hook for > legacy write implementations. So I don't need to worry about the control group stuff? I'll still need some way to flush a conflicting write whatever mechanism is being used to write to the page cache. David
