On Tue, Nov 15, 2022 at 12:44:46AM -0800, Christoph Hellwig wrote: > On Tue, Nov 15, 2022 at 12:30:40PM +1100, Dave Chinner wrote: > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > > > All the callers of xfs_bmap_punch_delalloc_range() jump through > > hoops to convert a byte range to filesystem blocks before calling > > xfs_bmap_punch_delalloc_range(). Instead, pass the byte range to > > xfs_bmap_punch_delalloc_range() and have it do the conversion to > > filesystem blocks internally. > > Ok, so we do this here. Why can't we just do this earlier and > avoid the strange inbetween stage with a wrapper? Probably to avoid rewriting the previous patch with this units change, is my guess. Dave, do you want to merge with this patch 4? I'm satisfied enough with patches 4 and 6 that I'd rather get this out to for-next for further testing than play more patch golf. Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx> --D
