On Fri, Nov 11, 2022 at 08:11:53AM -0500, Jeff Layton wrote: > ksmbd seems to be trying to use a cmd value of 0 when unlocking a file. > That activity requires a type of F_UNLCK with a cmd of F_SETLK. For > local POSIX locking, it doesn't matter much since vfs_lock_file ignores > @cmd, but filesystems that define their own ->lock operation expect to > see it set sanely. Btw, I really wonder if we should split vfs_lock_file into separate calls for locking vs unlocking. The current interface seems very confusing.