On Mon, Nov 14, 2022 at 10:02:38AM -0500, Jeff Layton wrote: > -int vfs_lock_file(struct file *filp, unsigned int cmd, struct file_lock *fl, struct file_lock *conf) > +int vfs_lock_file(unsigned int cmd, struct file_lock *fl, struct file_lock *conf) I'd pass fl as the first argument for a saner argument order here. Also can you please break the line at 80 characters? The previous version is insanely unreadable, and the new one just slightly less so. > +extern int vfs_lock_file(unsigned int, struct file_lock *, struct file_lock *); And please drop the pointless extern here. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
