On Sun 13-11-22 17:29:02, Christoph Hellwig wrote:
> ->writepage is a very inefficient method to write back data, and only
> used through write_cache_pages or a a fallback when no ->migrate_folio
> method is present.
>
> Set ->migrate_folio to the generic buffer_head based helper, and remove
> the ->writepage implementation in extfat.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Looks good. Feel free to add:
Acked-by: Jan Kara <jack@xxxxxxx>
Honza
> ---
> fs/udf/inode.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/fs/udf/inode.c b/fs/udf/inode.c
> index dce6ae9ae306c..0246b1b86fb91 100644
> --- a/fs/udf/inode.c
> +++ b/fs/udf/inode.c
> @@ -182,11 +182,6 @@ static void udf_write_failed(struct address_space *mapping, loff_t to)
> }
> }
>
> -static int udf_writepage(struct page *page, struct writeback_control *wbc)
> -{
> - return block_write_full_page(page, udf_get_block, wbc);
> -}
> -
> static int udf_writepages(struct address_space *mapping,
> struct writeback_control *wbc)
> {
> @@ -239,12 +234,12 @@ const struct address_space_operations udf_aops = {
> .invalidate_folio = block_invalidate_folio,
> .read_folio = udf_read_folio,
> .readahead = udf_readahead,
> - .writepage = udf_writepage,
> .writepages = udf_writepages,
> .write_begin = udf_write_begin,
> .write_end = generic_write_end,
> .direct_IO = udf_direct_IO,
> .bmap = udf_bmap,
> + .migrate_folio = buffer_migrate_folio,
> };
>
> /*
> --
> 2.30.2
>
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
