On 04/28/2009 07:00 PM, Christoph Hellwig wrote:
> We just did a full fs writeout using sync_filesystem before, and if
> that's not enough for the filesystem it can perform it's own writeout
> in ->put_super, which many filesystems already do.
>
> Move a call to foofs_write_super into every foofs_put_super for now to
> guarantee identical behaviour until it's cleaned up by the individual
> filesystem maintainers.
>
> Exceptions:
>
> - affs already has identical copy & pasted code at the beginning of
> affs_put_super so no need to do it twice.
> - xfs does the right thing without it and I have changes pending for
> the xfs tree touching this are so I don't really need conflicts
> here..
>
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
>
<snip>
> ===================================================================
> --- linux-2.6.orig/fs/exofs/super.c 2009-04-28 17:45:49.232482198 +0200
> +++ linux-2.6/fs/exofs/super.c 2009-04-28 17:47:50.303050752 +0200
> @@ -258,6 +258,9 @@ static void exofs_put_super(struct super
> int num_pend;
> struct exofs_sb_info *sbi = sb->s_fs_info;
>
> + if (sb->s_dirt)
> + exofs_write_super(sb);
> +
> /* make sure there are no pending commands */
> for (num_pend = atomic_read(&sbi->s_curr_pending); num_pend > 0;
> num_pend = atomic_read(&sbi->s_curr_pending)) {
Ack-by: Boaz Harrosh <bharrosh@xxxxxxxxxxx>
<snip>
I'll put it on my TODO list to see if this can be removed, later.
Boaz
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
