On Mon, Nov 07, 2022 at 10:55:49PM -0800, Christoph Hellwig wrote: > On Mon, Nov 07, 2022 at 09:56:07AM -0800, Keith Busch wrote: > > From: Jens Axboe <axboe@xxxxxxxxx> > > > > Like import_single_range(), but for ITER_UBUF. > > So what is the argument for not simplify switching > import_single_range to always do a ITER_UBUF? Maybe there is a reason > against that, but it should be clearly stated here. That may be a good idea if everyone uses the more efficient iter, but I thought it'd be safer to keep them separate. There are just a few import_single_range() users that expect the result be ITER_IOVEC. It will take some extra time on my side to make sure that kind of change won't break anything.