On 11/5/22 12:38 AM, David Howells wrote: > Fix the dodgy maths in netfs_rreq_unlock_folios(). start_page could be > inside the folio, in which case the calculation of pgpos will be come up > with a negative number (though for the moment rreq->start is rounded down > earlier and folios would have to get merged whilst locked) Hi, the patch itself seems fine. Just some questions about the scenario. 1. "start_page could be inside the folio" Is that because .expand_readahead() called from netfs_readahead()? Since otherwise, req-start is always aligned to the folio boundary. 2. If start_page is indeed inside the folio, then only the trailing part of the first folio can be covered by the request, and this folio will be marked with uptodate, though the beginning part of the folio may have not been read from the cache. Is that expected? Or correct me if I'm wrong. -- Thanks, Jingbo
