Hi Linus, Al, If we're going to go with Al's changes to switch to using ITER_SOURCE and ITER_DEST instead of READ/WRITE, can we put just the new symbols into mainline now, even if we leave the rest for the next merge window? Thanks, David --- From: Al Viro <viro@xxxxxxxxxxxxxxxxxx> iov_iter: Declare new iterator direction symbols READ/WRITE proved to be actively confusing - the meanings are "data destination, as used with read(2)" and "data source, as used with write(2)", but people keep interpreting those as "we read data from it" and "we write data to it", i.e. exactly the wrong way. Call them ITER_DEST and ITER_SOURCE - at least that is harder to misinterpret... [dhowells] Declare the symbols for later use and change to an enum. If READ/WRITE are switched to an enum also, I think the compiler should generate a warning if they're mixed. Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx> Signed-off-by: David Howells <dhowells@xxxxxxxxxx> Link: https://lore.kernel.org/r/20221028023352.3532080-12-viro@xxxxxxxxxxxxxxxxxx/ # v2 --- include/linux/uio.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/include/linux/uio.h b/include/linux/uio.h index 2e3134b14ffd..7c1317b34c57 100644 --- a/include/linux/uio.h +++ b/include/linux/uio.h @@ -29,6 +29,11 @@ enum iter_type { ITER_UBUF, }; +enum iov_iter_direction { + ITER_DEST = 0, /* Iterator is a destination buffer (== READ) */ + ITER_SOURCE = 1, /* Iterator is a source buffer (== WRITE) */ +}; + struct iov_iter_state { size_t iov_offset; size_t count;
