On Sun 26-04-09 09:31:42, Christoph Hellwig wrote: > Btw, I think calling quota_sync_sb for the !wait case in __fsync_super > might be a bad idea because it calls into ->sync_fs with wait = 1. Yes, I know this. I could hack it around so that quota is not synced at all when wait == 0 but it would be a bit surprising to future callers. But we could just call ->quota_sync() when wait == 0. That would basically do what's expected. I guess I'll do that. Honza PS: I've changed quota_sync_sb() to sync_quota_sb() and fixed one compile error when CONFIG_QUOTA is disabled in your patch. -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
