On Tue, Oct 25, 2022 at 10:24:01PM +0800, Dawei Li wrote: > For now there are no external callers of vfs_get_super(), > so just make it an internal API. > > base-commit: 3aca47127a646165965ff52803e2b269eed91afc > > Signed-off-by: Dawei Li <set_pte_at@xxxxxxxxxxx> > --- > fs/super.c | 3 +-- > include/linux/fs_context.h | 4 ---- > 2 files changed, 1 insertion(+), 6 deletions(-) > > diff --git a/fs/super.c b/fs/super.c > index 6a82660e1adb..cde412f900c7 100644 > --- a/fs/super.c > +++ b/fs/super.c > @@ -1136,7 +1136,7 @@ static int test_single_super(struct super_block *s, struct fs_context *fc) > * A permissions check is made by sget_fc() unless we're getting a superblock > * for a kernel-internal mount or a submount. > */ > -int vfs_get_super(struct fs_context *fc, > +static int vfs_get_super(struct fs_context *fc, > enum vfs_get_super_keying keying, > int (*fill_super)(struct super_block *sb, > struct fs_context *fc)) If you want to make it static that you should probably also make enum vfs_get_super_keying static by moving it into super.c. It's not used anywhere but for vfs_get_super() afaict.