On 10/14/22 11:07 AM, Jia Zhu wrote: > Previously, @ondemand_id field was used not only to identify ondemand > state of the object, but also to represent the index of the xarray. > This commit introduces @state field to decouple the role of @ondemand_id > and adds helpers to access it. > > Signed-off-by: Jia Zhu <zhujia.zj@xxxxxxxxxxxxx> > Reviewed-by: Xin Yin <yinxin.x@xxxxxxxxxxxxx> > --- > fs/cachefiles/internal.h | 22 ++++++++++++++++++++++ > fs/cachefiles/ondemand.c | 21 +++++++++------------ > 2 files changed, 31 insertions(+), 12 deletions(-) > > diff --git a/fs/cachefiles/internal.h b/fs/cachefiles/internal.h > index 2ad58c465208..39895bbd149a 100644 > --- a/fs/cachefiles/internal.h > +++ b/fs/cachefiles/internal.h > @@ -17,6 +17,7 @@ > #include <linux/security.h> > #include <linux/xarray.h> > #include <linux/cachefiles.h> > +#include <linux/atomic.h> ^ This is not needed any more. Otherwise LGTM. Reviewed-by: Jingbo Xu <jefflexu@xxxxxxxxxxxxxxxxx> -- Thanks, Jingbo