On 07/10/2022 16:37, Kees Cook wrote: > On Fri, Oct 07, 2022 at 10:47:01AM +0200, Ard Biesheuvel wrote: >> [...] >> Isn't this the stuff we want to move into the crypto API? > > It is, yes. Guilherme, for background: > https://lore.kernel.org/linux-crypto/20180802215118.17752-1-keescook@xxxxxxxxxxxx/ > Thanks a bunch Kees / Ard for pointing me that! But I'm confused with regards to the state of this conversion: the patches seem to be quite mature and work fine, but at the same time, they focus in what Herbert consider a deprecated/old API, so they were never merged right? The proposal from Ard (to move to crypto scomp/acomp) allow to rework the zbufsize worst case thing and wire it on such new API, correct? Do you intend to do that Kees? At the same time, I feel it is still valid to avoid these bunch of implicit conversions on pstore, as this patch proposes - what do you all think? I could rework this one on top of Ard's acomp migration while we don't have an official zbufsize API for on crypto scomp - and once we have, it'd be just a matter of removing the zbufsize functions of pstore and make use of the new API, which shouldn't be affected by this implicit conversion fix. Cheers, Guilherme
