> On Oct 5, 2022, at 6:06 AM, Jeff Layton <jlayton@xxxxxxxxxx> wrote:
>
> On Tue, 2022-10-04 at 10:39 +1100, NeilBrown wrote:
>> On Fri, 30 Sep 2022, Jeff Layton wrote:
>>>
>>> diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c
>>> index a5b71526cee0..9168bc657378 100644
>>> --- a/fs/nfsd/nfsfh.c
>>> +++ b/fs/nfsd/nfsfh.c
>>> @@ -634,6 +634,10 @@ void fh_fill_pre_attrs(struct svc_fh *fhp)
>>> stat.mtime = inode->i_mtime;
>>> stat.ctime = inode->i_ctime;
>>> stat.size = inode->i_size;
>>> + if (v4 && IS_I_VERSION(inode)) {
>>> + stat.version = inode_query_iversion(inode);
>>> + stat.result_mask |= STATX_VERSION;
>>> + }
>>
>> This is increasingly ugly. I wonder if it is justified at all...
>>
>
> I'm fine with dropping that. So if the getattrs fail, we should just not
> offer up pre/post attrs?
That sounds good to me.
--
Chuck Lever
