On Thu, Sep 29, 2022 at 12:51:28PM +0200, Christoph Hellwig wrote: > On Thu, Sep 29, 2022 at 11:46:23AM +0200, Christian Brauner wrote: > > +int do_set_acl(struct user_namespace *mnt_userns, struct dentry *dentry, > > + struct xattr_ctx *ctx) > > I'd just pass name, value an size instead of this weird context thing, > same for the read size. Otherwise this looks fine, though. Ok. > > > index 84180afd090b..b766ddfc6bc3 100644 > > --- a/io_uring/xattr.c > > +++ b/io_uring/xattr.c > > @@ -8,6 +8,7 @@ > > #include <linux/namei.h> > > #include <linux/io_uring.h> > > #include <linux/xattr.h> > > +#include <linux/posix_acl_xattr.h> > > This looks spurious. > Yes, leftover and already removed in the tree. Thanks!