Re: [PATCH v4 05/10] cachefiles: use vfs_tmpfile_open() helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Miklos Szeredi <mszeredi@xxxxxxxxxx>
Subject: Re: [PATCH v4 05/10] cachefiles: use vfs_tmpfile_open() helper
From: David Howells <dhowells@xxxxxxxxxx>
Date: Thu, 29 Sep 2022 09:44:45 +0100
Cc: dhowells@xxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Christian Brauner <brauner@xxxxxxxxxx>, Amir Goldstein <amir73il@xxxxxxxxx>, Yu-li Lin <yulilin@xxxxxxxxxx>, Chirantan Ekbote <chirantan@xxxxxxxxxxxx>
In-reply-to: <20220922084442.2401223-6-mszeredi@redhat.com>
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Miklos Szeredi <mszeredi@xxxxxxxxxx> wrote:

> -		path.dentry = vfs_tmpfile(&init_user_ns, fan, S_IFREG, O_RDWR);

Is there any point passing S_IFREG in to vfs_tmpfile()?  Can you actually make
a tmpfile that isn't a regular file?

David

Follow-Ups:
- Re: [PATCH v4 05/10] cachefiles: use vfs_tmpfile_open() helper
  - From: Miklos Szeredi

References:
- [PATCH v4 05/10] cachefiles: use vfs_tmpfile_open() helper
  - From: Miklos Szeredi
- [PATCH v4 00/10] fuse tmpfile
  - From: Miklos Szeredi

Prev by Date: Re: [PATCH v4 00/10] fuse tmpfile
Next by Date: Re: [PATCH v4] sched/numa: add per-process numa_balancing
Previous by thread: Re: [PATCH v4 00/10] fuse tmpfile
Next by thread: Re: [PATCH v4 05/10] cachefiles: use vfs_tmpfile_open() helper
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]