On Wed, Apr 22, 2009 at 05:56:21PM +0200, Jan Kara wrote: > These three functions are quite similar so merge them to save superblock list > traversal code. As a bonus we get livelock avoidance for all these superblock > traversals. Also remove the condition that if wait == 0 and sb->s_dirt is > not set, then ->sync_fs() is not called. This does not really make much sence > since s_dirt is generally used by filesystem to mean that ->write_super() needs > to be called. But ->sync_fs() does different things. I even suspect that some > filesystems (btrfs?) sets s_dirt just to fool this logic. Please separate the s_dirt bit out into a small patch, that's something we probably want for -stable, too. Otherwise the patch looks reasonable. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
