On Wed, 22 Apr 2009 16:40:00 -0500 Dave Kleikamp <shaggy@xxxxxxxxxxxxxxxxxx> wrote: > On Wed, 2009-04-22 at 14:10 -0700, Andrew Morton wrote: > > > roundup_to_blocksize() isn't a terribly good name, IMO. The name > > conveys no sense of what the function returns. It _sounds_ like it > > returns a "block size". But it doesn't - it returns a loff_t. > > round_up_file_offset_to_block_size() is a bit long though :( > > Is round_up_to_block() any better? I don't think the trailing "size" > helps. dunno. If the function is documented and if its arg is a loff_t rather than a bare ull then I guess that makes things sufficiently clear that we don't have to fuss about its name too much. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
