On Sat, 2022-09-24 at 10:17 -0400, liujing wrote: > Signed-off-by: liujing <liujing@xxxxxxxxxxxxxxxxxxxx> Generally it's better to have a commit message > diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c [] > @@ -989,6 +989,10 @@ __releases(fiq->lock) > > /* Allocate a buffer for the request */ > forget = kmalloc(sizeof(*forget), GFP_NOFS | __GFP_NOFAIL); > + A blank line is not typically used here. > + if (forget == NULL) > + return -ENOMEM; And this is unnecessary as __GFP_NOFAIL will do what it says. include/linux/gfp_types.h: * %__GFP_NOFAIL: The VM implementation _must_ retry infinitely: the caller * cannot handle allocation failures. The allocation could block * indefinitely but will never return with failure. Testing for * failure is pointless.
