Re: [PATCH 06/29] 9p: implement get acl method

[Al Viro <viro@xxxxxxxxxxxxxxxxxx>]

On Thu, Sep 22, 2022 at 05:17:04PM +0200, Christian Brauner wrote:
> +	struct v9fs_session_info *v9ses;
> +	struct posix_acl *acl = NULL;
> +
> +	v9ses = v9fs_dentry2v9ses(dentry);
> +	/* We allow set/get/list of acl when access=client is not specified. */
> +	if ((v9ses->flags & V9FS_ACCESS_MASK) != V9FS_ACCESS_CLIENT)
> +		acl = v9fs_acl_get(dentry, posix_acl_xattr_name(type));
> +	else
> +		acl = v9fs_get_cached_acl(d_inode(dentry), type);
> +	if (IS_ERR(acl))
> +		return acl;
> +
> +	return acl;

*blink*
	1.  Set acl to NULL, just in case.
	2.  Set acl to either one expression or another
	3.  If acl is an ERR_PTR(something), return acl
	4.  buggrit, return acl anyway.