On Sat, Sep 24, 2022 at 07:02:19AM +0200, Miklos Szeredi wrote: > On Sat, 24 Sept 2022 at 06:56, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > > > > On Fri, Sep 23, 2022 at 05:42:01PM +0200, Miklos Szeredi wrote: > > > On Thu, 22 Sept 2022 at 18:22, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > > > > > > > I would rather leave unobfuscating that to a separate patch, > > > > if not a separate series, but since you are touching > > > > cachefiles_unmark_inode_in_use() anyway, might as well > > > > get rid of if (inode) in there - it's equivalent to if (true). > > > > > > Okay, pushed updated version (also with > > > cachefiles_do_unmark_inode_in_use() un-open-coding) to: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git#fuse-tmpfile-v5 > > > > OK... I can live with that. Could you > > replace > > cachefiles_do_unmark_inode_in_use(object, file_inode(file)); > > with > > cachefiles_do_unmark_inode_in_use(object, inode); > > in there and repush? Or I could do cherry-pick and fix it up... > > Done. Head is now: > > 7d37539037c2 ("fuse: implement ->tmpfile()") Merged and pushed out.