On Wed, Sep 21, 2022 at 04:56:01PM +0200, Miklos Szeredi wrote: > On Wed, 21 Sept 2022 at 11:03, Christian Brauner <brauner@xxxxxxxxxx> wrote: > > > > On Tue, Sep 20, 2022 at 09:36:30PM +0200, Miklos Szeredi wrote: > > > > > +/* Helper for the simple case when original dentry is used */ > > > +static inline int finish_open_simple(struct file *file, int error) > > > > It would be nice if the new helpers would would be called > > vfs_finish_open()/vfs_finish_open_simple() and vfs_tmpfile_open() to > > stick with our vfs_* prefix convention. > > > > It is extremely helpful when looking/grepping for helpers and the > > consistency we have gained there in recent years is pretty good. > > Agreed. However only finish_open_simple() is the new one, and naming > it vfs_finish_open_simple() makes it inconsistent with > finish_open_simple(). I'd just leave this renaming to a separate > patchset and discussion, as it's hard enough to make progress with the > current one without expanding its scope. Ok, the finish_open* thing can be left for later. But vfs_tmpfile_open() should be doable for this patchset already.
