Hi Miklos, I love your patch! Perhaps something to improve: [auto build test WARNING on kdave/for-next] [also build test WARNING on jaegeuk-f2fs/dev-test linus/master v6.0-rc5] [cannot apply to viro-vfs/for-next next-20220916] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Miklos-Szeredi/cachefiles-tmpfile-error-handling-cleanup/20220917-034700 base: https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-next config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20220917/202209170555.zV70MRNl-lkp@xxxxxxxxx/config) compiler: m68k-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/87f47d099f22ea898e5d05215f9b2c4647012001 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Miklos-Szeredi/cachefiles-tmpfile-error-handling-cleanup/20220917-034700 git checkout 87f47d099f22ea898e5d05215f9b2c4647012001 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash fs/ext4/ fs/f2fs/ fs/minix/ fs/ramfs/ fs/ubifs/ fs/udf/ mm/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): In file included from include/linux/fs.h:8, from include/linux/dax.h:5, from mm/filemap.c:15: >> include/linux/dcache.h:253:30: warning: 'struct file' declared inside parameter list will not be visible outside of this definition or declaration 253 | extern void d_tmpfile(struct file *, struct inode *); | ^~~~ -- In file included from include/linux/fs.h:8, from mm/shmem.c:24: >> include/linux/dcache.h:253:30: warning: 'struct file' declared inside parameter list will not be visible outside of this definition or declaration 253 | extern void d_tmpfile(struct file *, struct inode *); | ^~~~ mm/shmem.c: In function 'shmem_tmpfile': mm/shmem.c:2930:27: error: passing argument 1 of 'd_tmpfile' from incompatible pointer type [-Werror=incompatible-pointer-types] 2930 | d_tmpfile(file, inode); | ^~~~ | | | struct file * include/linux/dcache.h:253:23: note: expected 'struct file *' but argument is of type 'struct file *' 253 | extern void d_tmpfile(struct file *, struct inode *); | ^~~~~~~~~~~~~ cc1: some warnings being treated as errors -- In file included from include/linux/fs.h:8, from fs/ext4/namei.c:28: >> include/linux/dcache.h:253:30: warning: 'struct file' declared inside parameter list will not be visible outside of this definition or declaration 253 | extern void d_tmpfile(struct file *, struct inode *); | ^~~~ fs/ext4/namei.c: In function 'ext4_tmpfile': fs/ext4/namei.c:2874:27: error: passing argument 1 of 'd_tmpfile' from incompatible pointer type [-Werror=incompatible-pointer-types] 2874 | d_tmpfile(file, inode); | ^~~~ | | | struct file * include/linux/dcache.h:253:23: note: expected 'struct file *' but argument is of type 'struct file *' 253 | extern void d_tmpfile(struct file *, struct inode *); | ^~~~~~~~~~~~~ cc1: some warnings being treated as errors -- In file included from include/linux/fs.h:8, from fs/f2fs/namei.c:8: >> include/linux/dcache.h:253:30: warning: 'struct file' declared inside parameter list will not be visible outside of this definition or declaration 253 | extern void d_tmpfile(struct file *, struct inode *); | ^~~~ fs/f2fs/namei.c: In function '__f2fs_tmpfile': fs/f2fs/namei.c:896:35: error: passing argument 1 of 'd_tmpfile' from incompatible pointer type [-Werror=incompatible-pointer-types] 896 | d_tmpfile(file, inode); | ^~~~ | | | struct file * include/linux/dcache.h:253:23: note: expected 'struct file *' but argument is of type 'struct file *' 253 | extern void d_tmpfile(struct file *, struct inode *); | ^~~~~~~~~~~~~ cc1: some warnings being treated as errors -- In file included from include/linux/fs.h:8, from fs/minix/minix.h:5, from fs/minix/namei.c:8: >> include/linux/dcache.h:253:30: warning: 'struct file' declared inside parameter list will not be visible outside of this definition or declaration 253 | extern void d_tmpfile(struct file *, struct inode *); | ^~~~ fs/minix/namei.c: In function 'minix_tmpfile': fs/minix/namei.c:63:27: error: passing argument 1 of 'd_tmpfile' from incompatible pointer type [-Werror=incompatible-pointer-types] 63 | d_tmpfile(file, inode); | ^~~~ | | | struct file * include/linux/dcache.h:253:23: note: expected 'struct file *' but argument is of type 'struct file *' 253 | extern void d_tmpfile(struct file *, struct inode *); | ^~~~~~~~~~~~~ cc1: some warnings being treated as errors -- In file included from include/linux/fs.h:8, from fs/ramfs/inode.c:26: >> include/linux/dcache.h:253:30: warning: 'struct file' declared inside parameter list will not be visible outside of this definition or declaration 253 | extern void d_tmpfile(struct file *, struct inode *); | ^~~~ fs/ramfs/inode.c: In function 'ramfs_tmpfile': fs/ramfs/inode.c:156:19: error: passing argument 1 of 'd_tmpfile' from incompatible pointer type [-Werror=incompatible-pointer-types] 156 | d_tmpfile(file, inode); | ^~~~ | | | struct file * include/linux/dcache.h:253:23: note: expected 'struct file *' but argument is of type 'struct file *' 253 | extern void d_tmpfile(struct file *, struct inode *); | ^~~~~~~~~~~~~ cc1: some warnings being treated as errors -- In file included from include/linux/fs.h:8, from fs/ubifs/ubifs.h:16, from fs/ubifs/dir.c:31: >> include/linux/dcache.h:253:30: warning: 'struct file' declared inside parameter list will not be visible outside of this definition or declaration 253 | extern void d_tmpfile(struct file *, struct inode *); | ^~~~ fs/ubifs/dir.c: In function 'ubifs_tmpfile': fs/ubifs/dir.c:479:19: error: passing argument 1 of 'd_tmpfile' from incompatible pointer type [-Werror=incompatible-pointer-types] 479 | d_tmpfile(file, inode); | ^~~~ | | | struct file * include/linux/dcache.h:253:23: note: expected 'struct file *' but argument is of type 'struct file *' 253 | extern void d_tmpfile(struct file *, struct inode *); | ^~~~~~~~~~~~~ cc1: some warnings being treated as errors -- In file included from include/linux/fs.h:8, from fs/udf/udfdecl.h:10, from fs/udf/namei.c:22: >> include/linux/dcache.h:253:30: warning: 'struct file' declared inside parameter list will not be visible outside of this definition or declaration 253 | extern void d_tmpfile(struct file *, struct inode *); | ^~~~ fs/udf/namei.c: In function 'udf_tmpfile': fs/udf/namei.c:643:19: error: passing argument 1 of 'd_tmpfile' from incompatible pointer type [-Werror=incompatible-pointer-types] 643 | d_tmpfile(file, inode); | ^~~~ | | | struct file * include/linux/dcache.h:253:23: note: expected 'struct file *' but argument is of type 'struct file *' 253 | extern void d_tmpfile(struct file *, struct inode *); | ^~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +253 include/linux/dcache.h 252 > 253 extern void d_tmpfile(struct file *, struct inode *); 254 -- 0-DAY CI Kernel Test Service https://01.org/lkp
