On Tue, Sep 13, 2022 at 02:25:01PM +0800, Jianglei Nie wrote: > } > - elfcorehdr_free(elfcorehdr_addr); > elfcorehdr_addr = ELFCORE_ADDR_ERR; > > proc_vmcore = proc_create("vmcore", S_IRUSR, NULL, &vmcore_proc_ops); > if (proc_vmcore) > proc_vmcore->size = vmcore_size; > - return 0; > + > +fail: > + elfcorehdr_free(elfcorehdr_addr); > + return rc; > } Did you test this? It looks like you now call elfcorehdr_free(ELFCORE_ADDR_ERR) if 'rc' is 0.