On Fri, Sep 09, 2022 at 10:03:39AM +0200, Christian Brauner wrote: > This passes xfstests (ext4, xfs, btrfs, overlayfs with and without > idmapped layers, and LTP). I only needed to add i_op->get_dentry_acl() > as it was possible to adapt ->set_acl() to take a dentry argument and > not an inode argument. This looks pretty nice. Two high level comments: - instead of adding lots of stub ->get_dentry_acl іmplementations that wrap ->get_acl, just call ->get_acl if ->get_dentry_acl is not implementet in the VFS - I think the methods that take a dentry should be named consisently, so either ->get_dentry_acl and ->get_dentry_acl vs ->get_acl, or ->get_acl and ->set_acl vs ->get_inode_acl or something like that.
