On Tue, 2022-09-06 at 17:01 +0100, David Howells wrote: > Jeff Layton <jlayton@xxxxxxxxxx> wrote: > > > If this or the other allocations below fail, do you need to free the > > prior ones here? Or do they automagically get cleaned up somehow? > > Once the fs_context is allocated, it will always get cleaned up with > put_fs_context(), which will dispose of the partially constructed > smack_mnt_opts struct. > Ok! In that case, you can add: Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx>