On Mon, Aug 29, 2022 at 02:38:41PM +0200, Christian Brauner wrote: > -static int posix_acl_fix_xattr_common(void *value, size_t size) > +static int posix_acl_fix_xattr_common(const void *value, size_t size) > { > - struct posix_acl_xattr_header *header = value; > + const struct posix_acl_xattr_header *header = value; This constification looks unrelated to the rest and isn't documented in the commit log. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>