On Fri, Aug 26, 2022 at 10:17:54AM -0700, Dan Williams wrote: > XFS always registers dax_holder_operations regardless of whether the > filesystem is capable of handling the notifications. The expectation is > that if the notify_failure handler cannot run then there are no > scenarios where it needs to run. In other words the expected semantic is > that page->index and page->mapping are valid for memory_failure() when > the conditions that cause -EOPNOTSUPP in xfs_dax_notify_failure() are > present. > > A fallback to the generic memory_failure() path is expected so do not > warn when that happens. Looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
