Hi! > > I do not think that we should harcode this here. I would be for a more > > dynamic approach, i.e. add a function into the tst_supported_fs_types.c > > that loops over supported filesystems and chooses max over the minimal > > values for all supported filesystems. That way if we run on embedded > > targets the device size will be 16MB as long as btrfs-progs is not > > installed. Also that way we can easily define minimal size for xfs 300MB > > and things will work for embedded as long as xfs-progs are not > > installed. > Correct. So the value for .all_filesystems should be maximum of supported > filesystems. The only think I don't like about it that it takes some time to > check everything (mkfs.* available ... etc), but we can't avoid it. > > Is it worth to cache this value (make it static in the function) so that it's not > searched more than once? Actually all we would need is a flag that would just return the pointer to the fs_types array from the tst_get_supported_fs_types() on second and subsequent calls. -- Cyril Hrubis chrubis@xxxxxxx
