Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: > > filemap_write_and_wait(inode->i_mapping); > > + truncate_pagecache_range(inode, off, old_eof); > > It's a bit odd to writeback the entire file but then truncate only part > of it. XFS does the same part: Actually, filemap_write_and_wait() should check for error, yes. Is there something that combines these that we should use? invalidate_inode_pages2_range() for example. David