On Sat, Aug 20, 2022 at 07:12:49PM +0100, Al Viro wrote:
> Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
LGTM. Feel free to add:
Reviewed-by: Matthew Bobrowski <repnop@xxxxxxxxxx>
> ---
> fs/notify/fanotify/fanotify.c | 2 +-
> fs/notify/fanotify/fanotify.h | 2 +-
> fs/notify/fanotify/fanotify_user.c | 6 +++---
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/fs/notify/fanotify/fanotify.c b/fs/notify/fanotify/fanotify.c
> index cd7d09a569ff..a2a15bc4df28 100644
> --- a/fs/notify/fanotify/fanotify.c
> +++ b/fs/notify/fanotify/fanotify.c
> @@ -18,7 +18,7 @@
>
> #include "fanotify.h"
>
> -static bool fanotify_path_equal(struct path *p1, struct path *p2)
> +static bool fanotify_path_equal(const struct path *p1, const struct path *p2)
> {
> return p1->mnt == p2->mnt && p1->dentry == p2->dentry;
> }
> diff --git a/fs/notify/fanotify/fanotify.h b/fs/notify/fanotify/fanotify.h
> index 1d9f11255c64..bf6d4d38afa0 100644
> --- a/fs/notify/fanotify/fanotify.h
> +++ b/fs/notify/fanotify/fanotify.h
> @@ -458,7 +458,7 @@ static inline bool fanotify_event_has_path(struct fanotify_event *event)
> event->type == FANOTIFY_EVENT_TYPE_PATH_PERM;
> }
>
> -static inline struct path *fanotify_event_path(struct fanotify_event *event)
> +static inline const struct path *fanotify_event_path(struct fanotify_event *event)
> {
> if (event->type == FANOTIFY_EVENT_TYPE_PATH)
> return &FANOTIFY_PE(event)->path;
> diff --git a/fs/notify/fanotify/fanotify_user.c b/fs/notify/fanotify/fanotify_user.c
> index f0e49a406ffa..4546da4a54f9 100644
> --- a/fs/notify/fanotify/fanotify_user.c
> +++ b/fs/notify/fanotify/fanotify_user.c
> @@ -249,7 +249,7 @@ static struct fanotify_event *get_one_event(struct fsnotify_group *group,
> return event;
> }
>
> -static int create_fd(struct fsnotify_group *group, struct path *path,
> +static int create_fd(struct fsnotify_group *group, const struct path *path,
> struct file **file)
> {
> int client_fd;
> @@ -619,7 +619,7 @@ static ssize_t copy_event_to_user(struct fsnotify_group *group,
> char __user *buf, size_t count)
> {
> struct fanotify_event_metadata metadata;
> - struct path *path = fanotify_event_path(event);
> + const struct path *path = fanotify_event_path(event);
> struct fanotify_info *info = fanotify_event_info(event);
> unsigned int info_mode = FAN_GROUP_FLAG(group, FANOTIFY_INFO_MODES);
> unsigned int pidfd_mode = info_mode & FAN_REPORT_PIDFD;
> @@ -1553,7 +1553,7 @@ static int fanotify_test_fid(struct dentry *dentry)
> }
>
> static int fanotify_events_supported(struct fsnotify_group *group,
> - struct path *path, __u64 mask,
> + const struct path *path, __u64 mask,
> unsigned int flags)
> {
> unsigned int mark_type = flags & FANOTIFY_MARK_TYPE_BITS;
> --
> 2.30.2
/M
