Re: [PATCH v5 2/4] selftests/landlock: Selftests for file truncation support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



FYI, my -next branch is here: https://git.kernel.org/pub/scm/linux/kernel/git/mic/linux.git/log/?h=next

Günther, let me know if everything is OK.

Konstantin, please rebase your work on it. It should mainly conflict with changes related to the Landlock ABI version.


On 19/08/2022 10:15, Mickaël Salaün wrote:
Ok, it should be in -next soon. Thanks for your contribution!

Would you like to write a syzkaller test to cover this new access right?
You only need to update the landlock_fs_accesses file with a call to
truncate() returning EACCES and check that it covers
hook_path_truncate(). You can take inspiration from this PR:
https://github.com/google/syzkaller/pull/3133
Please CC me, I can help.

Regards,
   Mickaël


On 19/08/2022 07:24, Günther Noack wrote:
On Thu, Aug 18, 2022 at 10:39:27PM +0200, Mickaël Salaün wrote:
On 17/08/2022 22:30, Günther Noack wrote:
+/*
+ * Invokes creat(2) and returns its errno or 0.
+ * Closes the opened file descriptor on success.
+ */
+static int test_creat(const char *const path, mode_t mode)

This "mode" argument is always 0600. If it's OK with you, I hard code this
mode and push this series to -next with some small cosmetic fixes.

Yes, absolutely. Please do these fixes and push it to -next. :)

Thanks,
—Günther

--



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux