Re: Switching to iterate_shared

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Subject: Re: Switching to iterate_shared
From: Matthew Wilcox <willy@xxxxxxxxxxxxx>
Date: Thu, 18 Aug 2022 15:35:18 +0100
Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx, coda@xxxxxxxxxx, codalist@xxxxxxxxxxxxxxxxxxxxxxxx, Namjae Jeon <linkinjeon@xxxxxxxxxx>, Sungjong Seo <sj1557.seo@xxxxxxxxxxx>, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx, devel@xxxxxxxxxxxxxxxxxx, linux-unionfs@xxxxxxxxxxxxxxx, linux-security-module@xxxxxxxxxxxxxxx, apparmor@xxxxxxxxxxxxxxxx, Hans de Goede <hdegoede@xxxxxxxxxx>
In-reply-to: <Yvvr447B+mqbZAoe@casper.infradead.org>

On Tue, Aug 16, 2022 at 08:11:31PM +0100, Matthew Wilcox wrote:
> fs/adfs/dir_f.c:        .iterate        = adfs_f_iterate,
> fs/adfs/dir_fplus.c:    .iterate        = adfs_fplus_iterate,
> 
> ADFS is read-only, so must be safe?

I just checked ADFS.  This isn't a f_ops ->iterate, this is a special
adfs_dir_ops.  ADFS already uses f_ops->iterate_shared.

References:
- [RFC][PATCH] Change calling conventions for filldir_t
  - From: Al Viro
- Re: [RFC][PATCH] Change calling conventions for filldir_t
  - From: Linus Torvalds
- Switching to iterate_shared
  - From: Matthew Wilcox

Prev by Date: Re: [PATCHv3 3/4] fs/buffer: Drop useless return value of submit_bh
Next by Date: Re: [RFC] problems with alloc_file_pseudo() use in __nfs42_ssc_open()
Previous by thread: Re: Switching to iterate_shared
Next by thread: Re: [apparmor] Switching to iterate_shared
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]