[PATCHv3 0/4] submit_bh: Drop unnecessary return value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



submit_bh/submit_bh_wbc are non-blocking functions which just submits
the bio and returns. The caller of submit_bh/submit_bh_wbc needs to wait
on buffer till I/O completion and then check buffer head's b_state field
to know if there was any I/O error.

Hence there is no need for these functions to have any return type.
Even now they always returns 0. Hence drop the return value and make
their return type as void to avoid any confusion.

PATCHv2 -> PATCHv3
===================
1. Rebased on top of the latest 6.0-rc1 release.
   Recently REQ_OP_** req operations and REQ_** flags were combined as one
   parameter (blk_opf_t type) to submit_bh() API.
2. Since the patch series remains trivial on rebase, I have retained the
   reviewed-by from Jan and Christoph.

RFC -> PATCHv2
===============
1. Added Patch-2 to fix ntfs_submit_bh_for_read() caller.
2. Added Reviewed-by from Christoph.

Ritesh Harjani (IBM) (4):
  jbd2: Drop useless return value of submit_bh
  fs/ntfs: Drop useless return value of submit_bh from ntfs_submit_bh_for_read
  fs/buffer: Drop useless return value of submit_bh
  fs/buffer: Make submit_bh & submit_bh_wbc return type as void

 fs/buffer.c                 | 23 ++++++++++-------------
 fs/jbd2/commit.c            | 10 ++++------
 fs/jbd2/journal.c           |  9 ++++-----
 fs/ntfs/file.c              |  4 ++--
 include/linux/buffer_head.h |  2 +-
 5 files changed, 21 insertions(+), 27 deletions(-)

--
2.35.3




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux