Re: [PATCH -next] fs/kernel_read_file: Fix some kernel-doc comments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 8/14/22 22:44, Yang Li wrote:
> Add a colon between the parameter name and description to meet the
> scripts/kernel-doc.
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1901
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>

Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Thanks.

> ---
>  fs/kernel_read_file.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/fs/kernel_read_file.c b/fs/kernel_read_file.c
> index 5d826274570c..c4fc84e6d099 100644
> --- a/fs/kernel_read_file.c
> +++ b/fs/kernel_read_file.c
> @@ -8,16 +8,16 @@
>  /**
>   * kernel_read_file() - read file contents into a kernel buffer
>   *
> - * @file	file to read from
> - * @offset	where to start reading from (see below).
> - * @buf		pointer to a "void *" buffer for reading into (if
> + * @file:	file to read from
> + * @offset:	where to start reading from (see below).
> + * @buf:	pointer to a "void *" buffer for reading into (if
>   *		*@buf is NULL, a buffer will be allocated, and
>   *		@buf_size will be ignored)
> - * @buf_size	size of buf, if already allocated. If @buf not
> + * @buf_size:	size of buf, if already allocated. If @buf not
>   *		allocated, this is the largest size to allocate.
> - * @file_size	if non-NULL, the full size of @file will be
> + * @file_size:	if non-NULL, the full size of @file will be
>   *		written here.
> - * @id		the kernel_read_file_id identifying the type of
> + * @id:	the kernel_read_file_id identifying the type of
>   *		file contents being read (for LSMs to examine)
>   *
>   * @offset must be 0 unless both @buf and @file_size are non-NULL

-- 
~Randy



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux