On 8/16/22 11:01 AM, Christian Brauner wrote: > On Tue, Aug 16, 2022 at 08:31:58AM -0700, Stefan Roesch wrote: >> This restores the call to inode_has_no_xattr() in the function >> __file_remove_privs(). In case the dentry_meeds_remove_privs() returned >> 0, the function inode_has_no_xattr() was not called. >> >> Signed-off-by: Stefan Roesch <shr@xxxxxx> >> --- > > Looks good to me. As Jens said, this should get a fixes tag and should > probably also have a link to the perf regression I debugged this on so > that we can see whether this was actually the cause, > Reviewed-by: Christian Brauner (Microsoft) <brauner@xxxxxxxxxx> Yes good point, this is a case where the Link actually makes a lot of sense. -- Jens Axboe