dcache header: 1. Remove a warning for dget_dlock 2. Add a similar comment for dget and mention the difference between dget and dget_dlock as suggested by Mr. Randy Dunlap Link: https://lore.kernel.org/all/29708eb3-ff1e-411e-cf84-7aa9af765603@xxxxxxxxxxxxx/ Signed-off-by: Anup K Parikh <parikhanupk.foss@xxxxxxxxx> --- include/linux/dcache.h | 24 +++++++++++++++++++----- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/include/linux/dcache.h b/include/linux/dcache.h index 92c78ed02..aa473b6bf 100644 --- a/include/linux/dcache.h +++ b/include/linux/dcache.h @@ -299,12 +299,15 @@ extern char *dentry_path(const struct dentry *, char *, int); /* Allocation counts.. */ /** - * dget, dget_dlock - get a reference to a dentry - * @dentry: dentry to get a reference to + * dget_dlock - get a reference to a dentry + * @dentry: dentry to get a reference to * - * Given a dentry or %NULL pointer increment the reference count - * if appropriate and return the dentry. A dentry will not be - * destroyed when it has references. + * Given a dentry or %NULL pointer increment the reference count + * if appropriate and return the dentry. A dentry will not be + * destroyed when it has references. + * + * The reference count increment in this function is not atomic. + * Consider dget() if atomicity is required. */ static inline struct dentry *dget_dlock(struct dentry *dentry) { @@ -313,6 +316,17 @@ static inline struct dentry *dget_dlock(struct dentry *dentry) return dentry; } +/** + * dget - get a reference to a dentry + * @dentry: dentry to get a reference to + * + * Given a dentry or %NULL pointer increment the reference count + * if appropriate and return the dentry. A dentry will not be + * destroyed when it has references. + * + * This function atomically increments the reference count. + * Consider dget_dlock() if atomicity is not required or manually managed. + */ static inline struct dentry *dget(struct dentry *dentry) { if (dentry) -- 2.35.1
