Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > if (iov_iter_is_bvec(new)) > return new->bvec = kmemdup(new->bvec, > new->nr_segs * sizeof(struct bio_vec), > flags); > - else > + else if (iov_iter_is_kvec(new) || iter_is_iovec(new)) The else is redundant. David