On Wed, Jul 27, 2022 at 01:49:00PM +0200, Sebastian Andrzej Siewior wrote: > This is v2 of the series, v1 is available at > https://https://lkml.kernel.org/r/.kernel.org/all/20220613140712.77932-1-bigeasy@xxxxxxxxxxxxx/ > > v1…v2: > - Make patch around Al's description of a bug in d_add_ci(). I took > the liberty to make him Author and added his signed-off-by since I > sinmply added a patch-body around his words. > > - The reasoning of why delaying the wakeup is reasonable has been > replaced with Al's analysis of the code. > > - The split of wake up has been done differently (and I hope this is > what Al meant). First the wake up has been pushed to the caller and > then delayed to end_dir_add() after preemption has been enabled. > > - There is still __d_lookup_unhash(), __d_lookup_unhash_wake() and > __d_lookup_done() is removed. > __d_lookup_done() is removed because it is exported and the return > value changes which will affect OOT users which are not aware of > it. > There is still d_lookup_done() which invokes > __d_lookup_unhash_wake(). This can't remain in the header file due > to cyclic depencies which in turn can't resolve wake_up_all() > within the inline function. Applied, with slightly different first commit (we only care about d_lookup_done() if d_splice_alias() returns non-NULL). See vfs.git#work.dcache.
