On Thu, Jul 28, 2022 at 08:32:32AM +1000, Dave Chinner wrote: > On Wed, Jul 27, 2022 at 09:04:25AM -0600, Keith Busch wrote: > > On Wed, Jul 27, 2022 at 03:04:56PM +0100, Al Viro wrote: > > > On Wed, Jul 27, 2022 at 07:58:29AM -0600, Keith Busch wrote: > > > > On Wed, Jul 27, 2022 at 12:12:53AM +0100, Al Viro wrote: > > > > > On Tue, Jul 26, 2022 at 10:38:13AM -0700, Keith Busch wrote: > > > > > > > > > > > + if (S_ISBLK(file_inode(file)->i_mode)) > > > > > > + bdev = I_BDEV(file->f_mapping->host); > > > > > > + else if (S_ISREG(file_inode(file)->i_mode)) > > > > > > + bdev = file->f_inode->i_sb->s_bdev; > > > > > > > > > > *blink* > > > > > > > > > > Just what's the intended use of the second case here? > > > > > > > > ?? > > > > > > > > The use case is same as the first's: dma map the user addresses to the backing > > > > storage. There's two cases here because getting the block_device for a regular > > > > filesystem file is different than a raw block device. > > > > > > Excuse me, but "file on some filesystem + block number on underlying device" > > > makes no sense as an API... > > > > Sorry if I'm misunderstanding your concern here. > > > > The API is a file descriptor + index range of registered buffers (which is a > > pre-existing io_uring API). The file descriptor can come from opening either a > > raw block device (ex: /dev/nvme0n1), or any regular file on a mounted > > filesystem using nvme as a backing store. > > That's fundamentally flawed. Filesystems can have multiple block > devices backing them that the VFS doesn't actually know about (e.g. > btrfs, XFS, etc). Further, some of these filesystems can spread > indiivdual file data across mutliple block devices i.e. the backing > bdev changes as file offset changes.... > > Filesystems might not even have a block device (NFS, CIFS, etc) - > what happens if you call this function on a file belonging to such a > filesystem? The block_device driver has to opt-in to this feature. If a multi-device block driver wants to opt-in to this, then it would be responsible to handle translating that driver's specific cookie to whatever representation the drivers it stacks atop require. Otherwise, the cookie threaded through the bio is an opque value: nothing between io_uring and the block_device driver need to decode it. If the block_device doesn't support providing this cookie, then io_uring just falls back to the existing less optimal methond, and all will continue to work as it does today.
