On Jul 19, 2022, at 12:56 PM, Axel Rasmussen <axelrasmussen@xxxxxxxxxx> wrote: > This new mode was recently added to the userfaultfd selftest. We want to > exercise both userfaultfd(2) as well as /dev/userfaultfd, so add both > test cases to the script. > > Reviewed-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx> > Acked-by: Peter Xu <peterx@xxxxxxxxxx> > Signed-off-by: Axel Rasmussen <axelrasmussen@xxxxxxxxxx> > --- > tools/testing/selftests/vm/run_vmtests.sh | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tools/testing/selftests/vm/run_vmtests.sh b/tools/testing/selftests/vm/run_vmtests.sh > index e70ae0f3aaf6..156f864030fc 100755 > --- a/tools/testing/selftests/vm/run_vmtests.sh > +++ b/tools/testing/selftests/vm/run_vmtests.sh > @@ -121,12 +121,17 @@ run_test ./gup_test -a > run_test ./gup_test -ct -F 0x1 0 19 0x1000 > > run_test ./userfaultfd anon 20 16 > +run_test ./userfaultfd anon:dev 20 16 > # Hugetlb tests require source and destination huge pages. Pass in half the > # size ($half_ufd_size_MB), which is used for *each*. > run_test ./userfaultfd hugetlb "$half_ufd_size_MB" 32 > +run_test ./userfaultfd hugetlb:dev "$half_ufd_size_MB" 32 > run_test ./userfaultfd hugetlb_shared "$half_ufd_size_MB" 32 "$mnt"/uffd-test > rm -f "$mnt"/uffd-test > +run_test ./userfaultfd hugetlb_shared:dev "$half_ufd_size_MB" 32 "$mnt"/uffd-test > +rm -f "$mnt"/uffd-test > run_test ./userfaultfd shmem 20 16 > +run_test ./userfaultfd shmem:dev 20 16 Do not do it if it would require another version of the patche-set, but otherwise, consider using a loop as I did in [1]. [1] https://lore.kernel.org/linux-mm/20220718114748.2623-6-namit@xxxxxxxxxx/
