On Fri, 15 Jul 2022 at 09:54, <williamsukatube@xxxxxxx> wrote: > > From: William Dean <williamsukatube@xxxxxxxxx> > > kfree() is missing on an error path to free the memory allocated by > kstrdup(): > > sb->s_subtype = kstrdup(parent_sb->s_subtype, GFP_KERNEL); > > So it is better to free it via kfree(sb->s_subtype). Not needed. s_subtype will be freed in __put_super(). Thanks, Miklos