On Thu, Jul 14, 2022 at 03:42:13PM -0700, Linus Torvalds wrote: > On Thu, Jul 14, 2022 at 3:32 PM Dave Chinner <david@xxxxxxxxxxxxx> wrote: > > > > Linus, can you please revert this commit for the 5.19 series (before > > the stable autosel bot sends it back to stable kernels, please!) to > > give us more time to investigate and consider the impact of the the > > API change on userspace applications before we commit to changing > > the API. > > Done. Thanks! > That said, even from the fastest output, I have to say that the new > behavior looks like the right one, and the old one just returned a > fantasy that didn't actually match what the dedupe operation actually > *did*. Very true, and I'm definitely not arguing that the change is wrong. We just need a bit of time to look at the various major dedupe apps and check that they still do the right thing w.r.t. proposed change. This late in the cycle I want to make sure we don't end up screwing things up and creating unnecessary urgent work for anyone in the near future... > But leaving this for later is not a problem. *nod* Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
