On Tue, Jul 12, 2022 at 11:47 AM Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxx> wrote:
>
> I suspect it should just check for inode->i_blkbits alignment. I think
> that's what DIO does, and it seems like a sane minimum.
.. actually, looking closer, DIO also knows about and tries to deal
with blksize_bits() of the underlying device.
Which makes sense for IO patterns, because that's basically the
"physical alignment" (vs "logical alignment") part.
However, from a filesystem dedupe standpoint, I think the logical
alignment is what matters, so just i_blkbits seems to be the best
model.
Linus
