There are couple of symbols missing documentation: fs/namei.c:649: warning: Function parameter or member 'mnt' not described in 'path_connected' fs/namei.c:649: warning: Function parameter or member 'dentry' not described in 'path_connected' fs/namei.c:1089: warning: Function parameter or member 'inode' not described in 'may_follow_link' Document them. Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/21] at: https://lore.kernel.org/all/cover.1657360984.git.mchehab@xxxxxxxxxx/ fs/namei.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/namei.c b/fs/namei.c index 1f28d3f463c3..a8079d6250bc 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -640,6 +640,8 @@ static bool nd_alloc_stack(struct nameidata *nd) /** * path_connected - Verify that a dentry is below mnt.mnt_root + * @mnt: pointer to vfs mount + * @dentry: pointer to dentry to verify * * Rename can sometimes move a file or directory outside of a bind * mount, path_connected allows those cases to be detected. @@ -1072,6 +1074,7 @@ fs_initcall(init_fs_namei_sysctls); /** * may_follow_link - Check symlink following for unsafe situations * @nd: nameidata pathwalk data + * @inode: inode to check * * In the case of the sysctl_protected_symlinks sysctl being enabled, * CAP_DAC_OVERRIDE needs to be specifically ignored if the symlink is -- 2.36.1
