Re: [PATCH v2 2/9] mm/mshare: pre-populate msharefs with information file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/30/22 17:01, Al Viro wrote:
On Wed, Jun 29, 2022 at 04:53:53PM -0600, Khalid Aziz wrote:

+static void
+mshare_evict_inode(struct inode *inode)
+{
+	clear_inode(inode);
+}

Again, what for?  And while we are at it, shouldn't you evict the
pages when inode gets freed and ->i_data along with it?
IOW, aren't you missing
                 truncate_inode_pages_final(&inode->i_data);
That, or just leave ->evict_inode NULL...

Good suggestion. I thought I would need to do more in evict_inode() but turned out I didn't. It is time to eject this routine from my code.

Thanks,
Khalid



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux