On Fri, Jul 1, 2022 at 4:55 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Fri, Jul 01, 2022 at 04:47:42PM +0800, David Gow wrote: > > Taint the kernel with TAINT_TEST whenever a test module loads, by adding > > a new "TEST" module property, and setting it for all modules in the > > tools/testing directory. This property can also be set manually, for > > tests which live outside the tools/testing directory with: > > MODULE_INFO(test, "Y"); > > > > Signed-off-by: David Gow <davidgow@xxxxxxxxxx> > > --- > > > > This patch is new in v4 of this series. > > > > --- > > kernel/module/main.c | 8 ++++++++ > > scripts/mod/modpost.c | 3 +++ > > 2 files changed, 11 insertions(+) > > > > diff --git a/kernel/module/main.c b/kernel/module/main.c > > index fed58d30725d..f2ca0a3ee5e6 100644 > > --- a/kernel/module/main.c > > +++ b/kernel/module/main.c > > @@ -1988,6 +1988,14 @@ static int check_modinfo(struct module *mod, struct load_info *info, int flags) > > /* Set up license info based on the info section */ > > set_license(mod, get_modinfo(info, "license")); > > > > + if (!get_modinfo(info, "test")) { > > + if (!test_taint(TAINT_TEST)) > > + pr_warn("%s: loading test module taints kernel.\n", > > + mod->name); > > + add_taint_module(mod, TAINT_TEST, LOCKDEP_STILL_OK); > > + } > > + > > + > > Why 2 blank lines? > > thanks, > > greg k-h Whoops: not sure where those came from. I've removed the extra newline locally: it'll be gone in the next revision. Cheers, -- David
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature