On Wed, 2022-06-22 at 05:15 +0100, Al Viro wrote:
> here nothing even looks at the iov_iter after the call, so we couldn't
> care less whether it advances or not.
>
> Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> ---
> fs/ceph/addr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
> index 6dee88815491..3c8a7cf19e5d 100644
> --- a/fs/ceph/addr.c
> +++ b/fs/ceph/addr.c
> @@ -329,7 +329,7 @@ static void ceph_netfs_issue_read(struct netfs_io_subrequest *subreq)
>
> dout("%s: pos=%llu orig_len=%zu len=%llu\n", __func__, subreq->start, subreq->len, len);
> iov_iter_xarray(&iter, READ, &rreq->mapping->i_pages, subreq->start, len);
> - err = iov_iter_get_pages_alloc(&iter, &pages, len, &page_off);
> + err = iov_iter_get_pages_alloc2(&iter, &pages, len, &page_off);
> if (err < 0) {
> dout("%s: iov_ter_get_pages_alloc returned %d\n", __func__, err);
> goto out;
There are some coming changes to make this code use an iter passed in as
part of the subreq, at which point we will need to advance this anyway.
Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx>
