On Sat, Jun 25, 2022 at 01:01:14PM +0200, Jason A. Donenfeld wrote: > This is already set by anon_inode_getfile(), since dma_buf_fops has > non-NULL ->llseek, so we don't need to set it here too. > > Suggested-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx> > Cc: Sumit Semwal <sumit.semwal@xxxxxxxxxx> > Cc: Christian König <christian.koenig@xxxxxxx> > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx > Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx> I'm assuming this is part of a vfs cleanup and lands through that tree? For that: Acked-by: Daniel Vetter <daniel.vetter@xxxxxxxx> > --- > drivers/dma-buf/dma-buf.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c > index 32f55640890c..3f08e0b960ec 100644 > --- a/drivers/dma-buf/dma-buf.c > +++ b/drivers/dma-buf/dma-buf.c > @@ -549,7 +549,6 @@ struct dma_buf *dma_buf_export(const struct dma_buf_export_info *exp_info) > goto err_dmabuf; > } > > - file->f_mode |= FMODE_LSEEK; > dmabuf->file = file; > > mutex_init(&dmabuf->lock); > -- > 2.35.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
