Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > + if (!aops->bmap) > > goto check_error; > > What are you doing using bmap? You really shouldn't call into it from > anywhere but FIBMAP. Yes, swap currently does but it's a major pain > in the neck and Peter has been working on a proper interface for swap > for a while. Checking to see whether there's a hole in the file. If there's a hole, that represents data I need to fetch; if there isn't that represents data I have in the cache. I don't care _where_ the data is, only whether it exists or not. David -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html